midori

Midori is a lightweight web browser.
Tasklist

FS#254 - arch:armv4 freerunner superuser warning sokoke

Attached to Project: midori
Opened by Maelvon (Maelvon) - Friday, 06 February 2009, 18:35 GMT+1
Last edited by Christian Dywan (kalikiana) - Sunday, 17 May 2009, 03:00 GMT+1
Task Type Bug Report
Category Core
Status Closed
Assigned To No-one
Operating System Linux
Severity Low
Priority Normal
Reported Version 0.0.17
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Hello,

I use Midori on an Freerunner "phone", and at Midori loading I've got a root usage warning blue line on top of the web page.

It's coming from the sokoke_superuser_warning_new() method in the "sokoke.c" file.

As the phone is running as root by default, this warning needs to be removed (I think so).
Perhaps with a ~/.Xresource value ? I don't know if it can be a possible solution. But if you have one to remove the warning line that use some pixels in that so small phone's screen.

Thanks fo the help,

Maelvon
This task depends upon

Closed by  Christian Dywan (kalikiana)
Sunday, 17 May 2009, 03:00 GMT+1
Reason for closing:  Fixed
Comment by Christian Dywan (kalikiana) - Saturday, 14 February 2009, 17:19 GMT+1
> As the phone is running as root by default

Is this a requirement for using the freerunner properly or something the user decides when uploading firmware? The warning is there because it is highly unwise to run a browser with unrestricted permissions. A phone can contain sensitive data or be abused as any other device.
(application/octet-stream)    . (0 KiB)
(application/octet-stream)    . (0 KiB)
Comment by Stuart Morrow (stuart) - Monday, 23 February 2009, 01:48 GMT+1
It's not a requirement, but it is the default (I don't know why), in the Openmoko distribution and in alternative distributions.
Since the phone is a special case (i.e., running as root is 'normal' for it), I think the warning message should be disabled on it, because it's probably an annoyance. But since most Midori users aren't on a Freerunner, obviously the warning should stay in the default build.

I think that choosing which style you want should be done at compile-time, then - not in an Xresource file.
Comment by Stuart Morrow (stuart) - Monday, 23 February 2009, 01:50 GMT+1
(which also means that the Openmoko (and FSO and so on) packaging people should be the ones to do this since they're the exception)
Comment by Pander (pander) - Saturday, 16 May 2009, 17:38 GMT+1
Offer in the Preferences/General tab a check box called "Show superuser warning" (default true) that when set to false will not display "Warning" you are using a superuser account!" Implementing this will allow OpenMoko and other handheld users to have more space on the screen of their device for viewing web pages. Perhaps even allow repackagers like SHR to set the default value to false. See also issue 196, which is sort of a duplicate of this issue.
Comment by Christian Dywan (kalikiana) - Sunday, 17 May 2009, 03:00 GMT+1
For what I want, I can't force my opinion about security upon anyone, and the warning was meant as a goodie in the first place. In fact, if every application is running with unlimited priviledges already, likely Midori isn't going to make a big difference.

And this is not worth a preference. Hence it is completely gone in git now.
(application/octet-stream)    . (0 KiB)

Loading...